This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($interval): do not use notify to trigger the callback
#13261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we are making this change to support a specific use case, shouldn't we add a test for that behavior? Otherwise someone else might refactor this back to what it was, and it would break again, |
|
@Narretz done! |
| promise.$$intervalId = setInterval(function tick() { | ||
| if (intervals[promise.$$intervalId]) { |
Do not use `$q.notify` to trigger the callback. This allows `$q` to be replaced with another Promise/A+ compilant library
lgalfaso
force-pushed
the
issue-12533
branch
from
9a3ee8c to
ec86090
Compare
gkalpak
pushed a commit
to gkalpak/angular.js
that referenced
this pull request
Nov 23, 2015
Do not use `$q.notify` to trigger the callback. This allows `$q` to be replaced with another Promise/A+ compilant library Closes: angular#13261
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use
$q.notifyto trigger the callback. This allows$qto be replacedwith another Promise/A+ compilant library
Note: this PR is not enough to close #12533, but should solve the main issue in trying to use Bluebird as a replacement of
$q